Repository navigation
Feat/app model download - #5
Merged
Merged
Conversation
saucer's macOS picker returns NSURL.absoluteString — a percent-encoded file:// URI (e.g. file:///Users/.../my%20model.gguf), not a POSIX path — so the app's fs::exists() check rejected every picked model with "backbone model not found". WebKitGTK returns a plain path, so the Linux container smoke never caught it (macOS-only). Add file_uri_to_path(): strip the file:// scheme and percent-decode. Apply it in pick_file (clean path in the setup textbox), in launch (before fs::exists and before save_config), and in load_config (so a config saved with a bad URI self-heals on next boot / auto-launch). Plain paths have no scheme and pass through untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
The desktop app could only *pick* existing .gguf files, so a user without models was stuck — while the start-zonos2 launchers download-if-missing. Add the same one-click path to the app's setup page: choose a quant and hit "Download & Launch" to fetch backbone + dac + (optional) spk-encoder from the public HF GGUF repo into <config>/models, with a live progress bar; then it launches as usual. "I already have the model files" still reveals the native pickers. Implementation mirrors the launcher and the app's existing ffmpeg fetch: system curl to a .part with resume + rc-33 (416) handling, ZONOS2_BASE_URL override, spk-encoder failure non-fatal (voice cloning disabled). Download runs on a background thread; the page polls a new download_status() exposed fn (byte count from the .part, denominator from a curl -sIL HEAD, falling back to a size table). A ZONOS2_APP_SELFTEST_DOWNLOAD=<quant> seam runs the download headlessly for tests/app-download-smoke.sh, wired into the linux-app CI job. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.